mirror of
https://github.com/pytorch/pytorch.git
synced 2026-11-20 09:04:25 +08:00
1d733d660d
Summary: Fixes https://github.com/pytorch/pytorch/issues/44195 cc: mruberry Pull Request resolved: https://github.com/pytorch/pytorch/pull/44615 Reviewed By: ngimel Differential Revision: D23703525 Pulled By: mruberry fbshipit-source-id: 471ebd764be667e29c03a30f3ef341440adc54d2
Note [TH abstraction violation] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TH/THC provide some hpp headers, which are proper C++ headers rather than C headers. These headers serve double duty as *internal implementation detail* headers, whose contents should largely not be used by external clients. Ideally, we would not install these headers at all; instead, you should use public functions (in headers like `THTensor.h`, NOT `THTensor.hpp`) to manipulate these structs. However, there are a few places in torch/csrc where we violate this abstraction. They are marked with a pointer to this note. Each of those sites will have to be refactored when we refactor the guts of THTensor and related structures.