mirror of
https://github.com/pytorch/pytorch.git
synced 2026-11-20 09:04:25 +08:00
use irange for loops 5 (#66744)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/66744 Modified loops in files under fbsource/fbcode/caffe2/ from the format `for(TYPE var=x0;var<x_max;x++)` to the format `for(const auto var: irange(xmax))` This was achieved by running r-barnes's loop upgrader script (D28874212) with some modification to exclude all files under /torch/jit and a number of reversions or unused variable suppression warnings added by hand. Test Plan: Sandcastle Reviewed By: ngimel Differential Revision: D31705358 fbshipit-source-id: d6ea350cbaa8f452fc78f238160e5374be637a48
This commit is contained in:
committed by
Facebook GitHub Bot
parent
bceb1db885
commit
e0643fa3fc
@@ -1,5 +1,6 @@
|
||||
#include <gtest/gtest.h>
|
||||
|
||||
#include <c10/util/irange.h>
|
||||
#include <torch/csrc/autograd/functions/comm.h>
|
||||
#include <torch/nn/module.h>
|
||||
#include <torch/nn/modules/conv.h>
|
||||
@@ -86,7 +87,7 @@ TEST_F(ParallelTest, Replicate_MultiCUDA) {
|
||||
}
|
||||
replicas[0]->to(torch::kCPU);
|
||||
ASSERT_EQ(replica1_parameters.size(), original_parameters.size());
|
||||
for (size_t i = 0; i < original_parameters.size(); ++i) {
|
||||
for (const auto i : c10::irange(original_parameters.size())) {
|
||||
ASSERT_TRUE(replica1_parameters[i].allclose(original_parameters[i]));
|
||||
ASSERT_TRUE(
|
||||
replica1_parameters[i].data_ptr<float>() !=
|
||||
@@ -99,7 +100,7 @@ TEST_F(ParallelTest, Replicate_MultiCUDA) {
|
||||
}
|
||||
replicas[1]->to(torch::kCPU);
|
||||
ASSERT_EQ(replica2_parameters.size(), original_parameters.size());
|
||||
for (size_t i = 0; i < original_parameters.size(); ++i) {
|
||||
for (const auto i : c10::irange(original_parameters.size())) {
|
||||
ASSERT_TRUE(replica2_parameters[i].allclose(original_parameters[i]));
|
||||
ASSERT_TRUE(
|
||||
replica2_parameters[i].data_ptr<float>() !=
|
||||
@@ -222,7 +223,7 @@ TEST_F(ParallelTest, DataParallelUsesAllAvailableCUDADevices_CUDA) {
|
||||
auto output = parallel::data_parallel(m, input);
|
||||
|
||||
ASSERT_EQ(output.numel(), device_count);
|
||||
for (size_t i = 0; i < device_count; ++i) {
|
||||
for (const auto i : c10::irange(device_count)) {
|
||||
ASSERT_EQ(output[i].item<int32_t>(), i);
|
||||
}
|
||||
}
|
||||
@@ -258,7 +259,7 @@ TEST_F(ParallelTest, DataParallelNumericalEquivalence_MultiCUDA) {
|
||||
auto model_dp = std::dynamic_pointer_cast<M>(model->clone());
|
||||
|
||||
// run 3 training iterations
|
||||
for (int i = 0; i < 3; ++i) {
|
||||
for (const auto i : c10::irange(3)) {
|
||||
input += i;
|
||||
input_dp += i;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user