mirror of
https://github.com/pytorch/pytorch.git
synced 2026-11-20 09:04:25 +08:00
Bag of clang tidy fixes for torch/csrc/ and torch/csrc/autograd (#11050)
Summary:
Linting `torch/csrc/` (non-recursive) and `torch/csrc/autograd` (non-recursive).
Fixed things like:
- `typedef` vs `using`
- Use `.empty()` instead of comparing with empty string/using `.size() == 0`
- Use range for loops instead of old style loops (`modernize-`)
- Remove some `virtual` + `override`
- Replace `stdint.h` with `cstdint`
- Replace `return Type(x, y)` with `return {x, y}`
- Use boolean values (`true`/`false`) instead of numbers (1/0)
- More ...
ezyang apaszke cpuhrsch
Pull Request resolved: https://github.com/pytorch/pytorch/pull/11050
Differential Revision: D9597505
Pulled By: goldsborough
fbshipit-source-id: cb0fb4793ade885a8dbf4b10484487b84c64c7f2
This commit is contained in:
committed by
Facebook Github Bot
parent
83a1ab2136
commit
dccd0f2de6
@@ -35,8 +35,7 @@ bool test_optimizer_xor(Options options) {
|
||||
const int64_t kBatchSize = 4;
|
||||
const int64_t kMaximumNumberOfEpochs = 3000;
|
||||
|
||||
auto optimizer = OptimizerClass(std::vector<torch::Tensor>(), options);
|
||||
optimizer.add_parameters(model->parameters());
|
||||
OptimizerClass optimizer(model->parameters(), options);
|
||||
|
||||
float running_loss = 1;
|
||||
int epoch = 0;
|
||||
@@ -152,6 +151,9 @@ TEST_CASE("Optim/BasicInterface") {
|
||||
REQUIRE(optimizer.size() == 0);
|
||||
optimizer.add_parameters(parameters);
|
||||
REQUIRE(optimizer.size() == parameters.size());
|
||||
for (size_t p = 0; p < parameters.size(); ++p) {
|
||||
REQUIRE(optimizer.parameters()[p].allclose(parameters[p]));
|
||||
}
|
||||
}
|
||||
{
|
||||
Linear linear(3, 4);
|
||||
|
||||
Reference in New Issue
Block a user