mirror of
https://github.com/pytorch/pytorch.git
synced 2026-11-20 09:04:25 +08:00
A few additions (#9837)
Summary:
This PR provides 4 fixes / features:
1. torch::nn::Cloneable inherits virtually from torch::nn::Module. We want to pass around a module with new functions, and the best way to do this is to do a diamond inheritance pattern, i.e.
```c++
struct MySuperModuleImpl : virtual public torch::nn::Module {
virtual void myFunction() = 0;
}
struct MySuperModule : public torch::nn::Cloneable<MySuperModule>, MySuperModuleImple {};
struct MyModule : public MySuperModule<MyModule> {
void myFunction() override;
};
```
This way, we can simply pass around MySuperModuleImpl around instead of torch::nn::Module.
2. Optimizer options are public now, since there's no way to decay the LR or modify it during training otherwise
3. Serialization functions creates autograd history and calls copy_! Bad!
4. Optimizers did not create buffers after add_parameters was called.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/9837
Reviewed By: goldsborough
Differential Revision: D9199746
Pulled By: ebetica
fbshipit-source-id: 76d6b22e589a42637b7cc0b5bcd3c6b6662fb299
This commit is contained in:
committed by
Facebook Github Bot
parent
0a39a9cfbc
commit
b8530dc1f0
@@ -289,7 +289,7 @@ TEST_CASE("module/clone") {
|
||||
a->module->weight.data() += 1;
|
||||
a->module->value = 123;
|
||||
|
||||
auto b = std::static_pointer_cast<NestedModule>(a->clone());
|
||||
auto b = std::dynamic_pointer_cast<NestedModule>(a->clone());
|
||||
|
||||
REQUIRE(!pointer_equal(b->module->weight, a->module->weight));
|
||||
REQUIRE(
|
||||
|
||||
Reference in New Issue
Block a user