mirror of
https://github.com/pytorch/pytorch.git
synced 2026-11-20 09:04:25 +08:00
Correctly restore pybind11 error_already_set (#93238)
We would handle py::error_already_set correctly from pybind11 bindings, but not from our regular TH bindings, which meant that anything from an inner pybind11 function call was getting unconditionally transformed into a RuntimeError. Not too many cases where we do this, but PySymNodeImpl was one of them. To test this, I need to raise a non-RuntimeError from a function which is invoked from pybind11 and then propagated to a non-pybind11 call site. I introduce GuardOnDataDependentSymNode for expressly this purpose (this is how I discovered the bug anyway.) Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/93238 Approved by: https://github.com/Skylion007, https://github.com/albanD
This commit is contained in:
committed by
PyTorch MergeBot
parent
3e4d0e8d82
commit
434eb16deb
@@ -1579,7 +1579,7 @@ $0 = torch._ops.aten.empty.memory_format([], device=device(type='cpu'), pin_memo
|
||||
|
||||
err_msg = "no implementation found for 'torch.ops.aten.sym_stride'"
|
||||
e = StridesNotImplemented(torch.randn(3, 3), use_wrapper_subclass)
|
||||
with self.assertRaisesRegex(RuntimeError, err_msg):
|
||||
with self.assertRaisesRegex(TypeError, err_msg):
|
||||
e.stride()
|
||||
|
||||
e = StridesCustomReturn(torch.randn(3, 3), use_wrapper_subclass)
|
||||
@@ -1631,7 +1631,7 @@ $0 = torch._ops.aten.empty.memory_format([], device=device(type='cpu'), pin_memo
|
||||
|
||||
err_msg = "no implementation found for 'torch.ops.aten.sym_size'"
|
||||
e = SizesNotImplemented(torch.randn(3, 3), use_wrapper_subclass)
|
||||
with self.assertRaisesRegex(RuntimeError, err_msg):
|
||||
with self.assertRaisesRegex(TypeError, err_msg):
|
||||
e.size()
|
||||
|
||||
e = SizesCustomReturn(torch.randn(3, 3), use_wrapper_subclass)
|
||||
|
||||
Reference in New Issue
Block a user