Use torch:: instead of at:: in all C++ APIs (#13523)

Summary:
In TorchScript and C++ extensions we currently advocate a mix of `torch::` and `at::` namespace usage. In the C++ frontend I had instead exported all symbols from `at::` and some from `c10::` into the `torch::` namespace. This is far, far easier for users to understand, and also avoid bugs around creating tensors vs. variables. The same should from now on be true for the TorchScript C++ API (for running and loading models) and all C++ extensions.

Note that since we're just talking about typedefs, this change does not break any existing code.

Once this lands I will update stuff in `pytorch/tutorials` too.

zdevito ezyang gchanan
Pull Request resolved: https://github.com/pytorch/pytorch/pull/13523

Differential Revision: D12942787

Pulled By: goldsborough

fbshipit-source-id: 76058936bd8707b33d9e5bbc2d0705fc3d820763
This commit is contained in:
Peter Goldsborough
2018-11-06 14:28:20 -08:00
committed by Facebook Github Bot
parent be424de869
commit 393ad6582d
90 changed files with 158 additions and 164 deletions
+4 -4
View File
@@ -3,7 +3,7 @@
#include <torch/nn/module.h>
#include <torch/nn/modules/linear.h>
#include <torch/nn/modules/rnn.h>
#include <torch/tensor.h>
#include <torch/types.h>
#include <torch/utils.h>
#include <test/cpp/api/support.h>
@@ -54,8 +54,8 @@ TEST_F(ModuleTest, ZeroGrad) {
TEST_F(ModuleTest, ZeroGradWithUndefined) {
struct TestModule : torch::nn::Module {
TestModule() {
x = register_parameter("x", torch::ones(5, at::requires_grad()));
y = register_parameter("y", torch::ones(5, at::requires_grad()));
x = register_parameter("x", torch::ones(5, torch::requires_grad()));
y = register_parameter("y", torch::ones(5, torch::requires_grad()));
}
torch::Tensor x, y;
};
@@ -194,7 +194,7 @@ TEST_F(ModuleTest, Conversion_MultiCUDA) {
ASSERT_EQ(parameter->device().type(), torch::Device::Type::CUDA);
ASSERT_EQ(parameter->device().index(), 0);
}
module->to({at::kCUDA, 1});
module->to({torch::kCUDA, 1});
for (auto& parameter : module->parameters()) {
ASSERT_EQ(parameter->device().type(), torch::Device::Type::CUDA);
ASSERT_EQ(parameter->device().index(), 1);