Add OptimizerBase::add_parameters (#9472)

Summary:
ebetica asked for a way to add parameters to `Optimizer`s after they are created.

ebetica ezyang
Pull Request resolved: https://github.com/pytorch/pytorch/pull/9472

Differential Revision: D8872176

Pulled By: goldsborough

fbshipit-source-id: 39a4032c519a6d3b458dd3596361b04afea10365
This commit is contained in:
Peter Goldsborough
2018-07-17 13:58:17 -07:00
committed by Facebook Github Bot
parent 890037eaaf
commit 2249751422
5 changed files with 111 additions and 40 deletions
+24
View File
@@ -135,6 +135,30 @@ void check_exact_values(
}
}
TEST_CASE("Optim/BasicInterface") {
struct MyOptimizer : Optimizer {
using Optimizer::Optimizer;
void step() override {}
};
std::vector<torch::Tensor> parameters = {
torch::ones({2, 3}), torch::zeros({2, 3}), torch::rand({2, 3})};
{
MyOptimizer optimizer(parameters);
REQUIRE(optimizer.size() == parameters.size());
}
{
MyOptimizer optimizer;
REQUIRE(optimizer.size() == 0);
optimizer.add_parameters(parameters);
REQUIRE(optimizer.size() == parameters.size());
}
{
Linear linear(3, 4);
MyOptimizer optimizer(linear->parameters());
REQUIRE(optimizer.size() == linear->parameters().size());
}
}
TEST_CASE("Optim/XORConvergence/SGD") {
REQUIRE(test_optimizer_xor<SGD>(
SGDOptions(0.1).momentum(0.9).nesterov(true).weight_decay(1e-6)));