Commit Graph

27 Commits

Author SHA1 Message Date
dmiller c6ae85544d Limit db2 packet to size needed for info struct 2026-09-14 17:42:06 +00:00
nnposter 8f88a575f4 Fix spelling of "endianness". Closes #2850 2024-06-12 23:42:55 +00:00
dmiller 5bffa604d9 Remove bin.lua unpacking from more scripts 2018-09-08 17:07:00 +00:00
dmiller f20589ca09 Use explicit endianness in pack/unpack. 2017-02-14 03:47:49 +00:00
dmiller cb4b46bd53 Canonicalize authors as tables instead of comma-separated strings 2016-06-09 22:46:42 +00:00
dmiller f4619edece Update http urls for nmap.org to https 2015-11-05 20:41:05 +00:00
dmiller 0e74dd7a35 Replace some string.char and bin.pack calls with literals 2015-02-27 19:42:56 +00:00
dmiller 10dce0382c Clean up string concatenations
Building a string with var = var .. "something" has miserable time
complexities. This commit cleans up a lot of that in scripts, focusing
on packing of data with bin.pack and concatenations within loops.
Additionally, a few instances were replaced with string.rep
2015-02-25 19:58:42 +00:00
dmiller 40f36a4e3e Some string optimizations in NSE
Changes fall into these categories:

1. Avoid pathological string building. Loops over x = x .. "foo" can
become very slow. Instead, use strbuf.lua, table.concat, or just one
continuous concatenation; a = x .. y .. z is one operation, better than
a = x .. y; a = a .. z

2. Use hex-escaped strings instead of string.char. I find this more
readable in many cases, and it avoids a table lookup and function call.

3. Don't duplicate code. A few libraries and scripts had re-implemented
stdnse.generate_random_string or openssl.rand_bytes.
2014-09-03 04:49:54 +00:00
batrick aeb5908481 more stdnse.print_debug -> stdnse.debug
Manual corrections.
2014-08-02 02:54:47 +00:00
batrick 536075d3af stdnse.print_debug -> stdnse.debug
$ sed -i 's/stdnse.print_debug("[-a-z0-9]*:\s*\([^"]*\)"/stdnse.debug1("\1"/' *.nse
$ sed -i 's/stdnse.print_debug(\([0-9]*\),\s*"[-a-z0-9]*:\s*\([^"]*\)"/stdnse.debug\1("\2"/' *.nse

Except:
  o eap-info.nse
  o oracle-brute.nse

Modified:
  o couchdb-databases.nse
  o couchdb-stats.nse
  o http-open-redirect.nse
2014-08-01 23:04:55 +00:00
dmiller 1b71f75aad Spelling fixes for Lua files
Mostly in documentation/comments, but a couple code bugs were caught,
including a call to stdnse.pirnt_debug and a mis-declared variable.
2014-02-19 04:15:46 +00:00
dmiller a084340b6d Remove useless calls to string.format
stdnse.print_debug accepts a format string and arguments, making
string.format redundant in calls of this form:

stdnse.print_debug(1, string.format("%s: error", SCRIPT_NAME))
stdnse.print_debug(("length %d"):format(#tab))

These can be rewritten as:

stdnse.print_debug(1, "%s: error", SCRIPT_NAME)
stdnse.print_debug("length %d", #tab)
2014-02-13 15:47:41 +00:00
dmiller 31a2c432e1 Final re-indent for scripts. 2014-02-02 15:33:39 +00:00
dmiller 620f9fdb34 Remove trailing whitespace in lua files
Whitespace is not significant, so this should not be a problem.
https://secwiki.org/w/Nmap/Code_Standards
2014-01-23 21:51:58 +00:00
dmiller 4bbb4366d2 Fix name_confidence use (0-10, not 0-100) 2013-10-23 16:36:26 +00:00
david a2c2863531 Remove "hardmatched" argument from calls to nmap.set_port_version.
This is the default and can be omitted. Seeing as the value of this
argument was "hardmatched" in 100% of cases, we're better off pretending
the parameter doesn't exist.
2012-07-30 18:58:32 +00:00
patrik 7d01a00cfc bug fix in db2-das-info for error in replacement string;
invalid use of '%' in replacement string
2012-06-16 19:58:45 +00:00
perdo 5ac6c7d64a Fixed errors found by nse_check_globals. 2012-06-06 22:23:02 +00:00
batrick 000f6dc4d9 Lua 5.2 upgrade [1] for NSE.
[1] http://seclists.org/nmap-dev/2012/q2/34
2012-05-27 08:53:32 +00:00
tomsellers c8fb3889e6 Addressed a condition in db2-das-info.nse where the script would crash
if the DB2 DAS service had discovery mode disabled.  While the service
would be listening, the data would be in an unexpected format.  This 
caused the script to crash at line 412 when it tried to extract the 
server profile from the DB2 response (db2response.info variable).

I will likely tweak the hard setting of the ports in the block that
follows after I perform more testing to verify that it behaves as
expected - Tom
2011-02-16 00:13:38 +00:00
david 3c89e089fc Change calls in these forms:
socket:connect(host.ip, port.number)
socket:connect(host.ip, port.number, port.protocol)

to this:

socket:connect(host, port)

connect can take host and port tables now, and the default protocol is
taken from the port table if possible.
2010-08-16 18:59:30 +00:00
djalal 72a06a3b5c Merge r18160:18278 from nmap-exp/djalal/nmap-nse/ to fix NSE not honoring the exclude directive bug. 2010-06-29 21:56:59 +00:00
fyodor 35a28ea343 canonicalize some license text that differed in whitespace or quote character or line-ending or (in a couple cases) the slightly older wording 2010-06-11 06:54:56 +00:00
david 8a26459cfd Add @output sections for http-passwd, db2-info, db2-das-info, and
pptp-version.
2010-04-08 19:44:20 +00:00
tomsellers 1135590980 Modified portrule to restrict the script to port 523 instead of 523 OR ibm-db2
in order to keep the script from running against the actual database instances.
Also modified the debugging output so that the bulk of the information is 
generated at -d 4 or higher.
2010-01-29 00:51:55 +00:00
tomsellers 9f9ce26425 Add a new script, db2-das-info.nse, that connects to the IBM DB2 Administration Server (DAS)
on TCP or UDP port 523 and exports the server profile.  No authentication is required for 
this request. The script will also set the port product and version if a version scan is
requested. [Patrik Karlsson, Tom Sellers]
2010-01-28 00:48:29 +00:00