From ee4e7a2ffd18b6ea9bf16ffef6dddfe9bcb91557 Mon Sep 17 00:00:00 2001 From: Dery Ferdika <114888155+DeryFerd@users.noreply.github.com> Date: Mon, 2 Nov 2026 19:30:23 +0700 Subject: [PATCH] refactor(shields): centralize duplicated REA limits in identity.ts (#66) REA_ASAR_HEADER_LIMITS / REA_FRIDA_CAPTURE_LIMITS / REA_REGEX_WORKER_LIMITS were redeclared in three exhaustion shields instead of referencing REA_INTERNAL_LIMITS, so npm run verify:rea (which only checks identity.ts) could miss drift voiding the budget-exhaustion claim. Move ASAR/Frida/Regex constants into REA_INTERNAL_LIMITS (WASM already used this pattern) and import at each site; verify:rea drift profile unchanged. --- src/identity.ts | 21 +++++++++++++++++++ .../exhaustion/asar-header-amplifier.ts | 10 +++++---- .../exhaustion/frida-capture-saturation.ts | 17 ++++++++------- src/shields/exhaustion/regex-worker-tarpit.ts | 11 ++++++---- 4 files changed, 44 insertions(+), 15 deletions(-) diff --git a/src/identity.ts b/src/identity.ts index 88b0835..626b9a4 100644 --- a/src/identity.ts +++ b/src/identity.ts @@ -186,4 +186,25 @@ export const REA_INTERNAL_LIMITS = Object.freeze({ UF2_BLOCK_BYTES: 512, UF2_DATA_BYTES: 476, UF2_MAX_REGIONS: 65_536, + /** + * Electron ASAR header admission (`electronAsar.ts`: `DEFAULT_ASAR_MAX_HEADER_BYTES` + * / `MAXIMUM_ASAR_MAX_HEADER_BYTES`). + */ + ASAR_DEFAULT_MAX_HEADER_BYTES: 16 * 1024 * 1024, + ASAR_MAXIMUM_MAX_HEADER_BYTES: 256 * 1024 * 1024, + /** + * Frida capture limits (`src/frida/fridaCaptureLimits.ts:2-11`). + */ + FRIDA_MAX_SESSION_CAPTURE_BYTES: 16 * 1024 * 1024, + FRIDA_MAX_MESSAGE_METADATA_BYTES: 128 * 1024, + FRIDA_MAX_MESSAGE_TYPE_BYTES: 4 * 1024, + FRIDA_MAX_MESSAGE_TEXT_BYTES: 32 * 1024, + FRIDA_MAX_CAPTURE_JSON_NODES: 250_000, + FRIDA_MAX_JSON_DEPTH: 64, + /** + * Regex worker budgets (`src/domain/analysisResourceLimits.ts:38,50`). + */ + REGEX_DEFAULT_MATCHING_DEADLINE_MS: 5_000, + REGEX_DEFAULT_WORKER_HEAP_REQUEST_MIB: 128, + REGEX_MINIMUM_WORKER_HEAP_REQUEST_MIB: 7, }); diff --git a/src/shields/exhaustion/asar-header-amplifier.ts b/src/shields/exhaustion/asar-header-amplifier.ts index 8a10b99..0a463d5 100644 --- a/src/shields/exhaustion/asar-header-amplifier.ts +++ b/src/shields/exhaustion/asar-header-amplifier.ts @@ -1,14 +1,16 @@ import { SeededPrng } from "../../core/prng.js"; import type { ProtectionIntensity } from "../../core/types.js"; +import { REA_INTERNAL_LIMITS } from "../../identity.js"; import type { VirtualAsarFile } from "../formats/asar.js"; /** - * Exact constants from REA ASAR header admission - * (`DEFAULT_ASAR_MAX_HEADER_BYTES` / `MAXIMUM_ASAR_MAX_HEADER_BYTES`). + * REA ASAR header admission limits — values centralized in + * `REA_INTERNAL_LIMITS` (`src/identity.ts`) so `verify:rea` drift checks cover + * them alongside every other REA constant. */ export const REA_ASAR_HEADER_LIMITS = { - DEFAULT_ASAR_MAX_HEADER_BYTES: 16 * 1024 * 1024, - MAXIMUM_ASAR_MAX_HEADER_BYTES: 256 * 1024 * 1024, + DEFAULT_ASAR_MAX_HEADER_BYTES: REA_INTERNAL_LIMITS.ASAR_DEFAULT_MAX_HEADER_BYTES, + MAXIMUM_ASAR_MAX_HEADER_BYTES: REA_INTERNAL_LIMITS.ASAR_MAXIMUM_MAX_HEADER_BYTES, } as const; export interface AsarHeaderAmplificationPlan { diff --git a/src/shields/exhaustion/frida-capture-saturation.ts b/src/shields/exhaustion/frida-capture-saturation.ts index 338095c..7b737d3 100644 --- a/src/shields/exhaustion/frida-capture-saturation.ts +++ b/src/shields/exhaustion/frida-capture-saturation.ts @@ -1,16 +1,19 @@ import { SeededPrng } from "../../core/prng.js"; import type { ProtectionIntensity } from "../../core/types.js"; +import { REA_INTERNAL_LIMITS } from "../../identity.js"; /** - * Exact constants from `morluto/rea/src/frida/fridaCaptureLimits.ts:2-11`. + * REA Frida capture limits (`morluto/rea/src/frida/fridaCaptureLimits.ts:2-11`) + * — values centralized in `REA_INTERNAL_LIMITS` (`src/identity.ts`) so + * `verify:rea` drift checks cover them alongside every other REA constant. */ export const REA_FRIDA_CAPTURE_LIMITS = { - MAX_SESSION_CAPTURE_BYTES: 16 * 1024 * 1024, - MAX_MESSAGE_METADATA_BYTES: 128 * 1024, - MAX_MESSAGE_TYPE_BYTES: 4 * 1024, - MAX_MESSAGE_TEXT_BYTES: 32 * 1024, - MAX_CAPTURE_JSON_NODES: 250_000, - MAX_JSON_DEPTH: 64, + MAX_SESSION_CAPTURE_BYTES: REA_INTERNAL_LIMITS.FRIDA_MAX_SESSION_CAPTURE_BYTES, + MAX_MESSAGE_METADATA_BYTES: REA_INTERNAL_LIMITS.FRIDA_MAX_MESSAGE_METADATA_BYTES, + MAX_MESSAGE_TYPE_BYTES: REA_INTERNAL_LIMITS.FRIDA_MAX_MESSAGE_TYPE_BYTES, + MAX_MESSAGE_TEXT_BYTES: REA_INTERNAL_LIMITS.FRIDA_MAX_MESSAGE_TEXT_BYTES, + MAX_CAPTURE_JSON_NODES: REA_INTERNAL_LIMITS.FRIDA_MAX_CAPTURE_JSON_NODES, + MAX_JSON_DEPTH: REA_INTERNAL_LIMITS.FRIDA_MAX_JSON_DEPTH, } as const; export interface FridaCaptureSaturationResult { diff --git a/src/shields/exhaustion/regex-worker-tarpit.ts b/src/shields/exhaustion/regex-worker-tarpit.ts index 3da326c..3a4c545 100644 --- a/src/shields/exhaustion/regex-worker-tarpit.ts +++ b/src/shields/exhaustion/regex-worker-tarpit.ts @@ -1,13 +1,16 @@ import { SeededPrng } from "../../core/prng.js"; import type { ProtectionIntensity } from "../../core/types.js"; +import { REA_INTERNAL_LIMITS } from "../../identity.js"; /** - * Exact constants from `morluto/rea/src/domain/analysisResourceLimits.ts:38,50`. + * REA regex worker budgets (`morluto/rea/src/domain/analysisResourceLimits.ts:38,50`) + * — values centralized in `REA_INTERNAL_LIMITS` (`src/identity.ts`) so + * `verify:rea` drift checks cover them alongside every other REA constant. */ export const REA_REGEX_WORKER_LIMITS = { - DEFAULT_REGEX_MATCHING_DEADLINE_MS: 5_000, - DEFAULT_REGEX_WORKER_HEAP_REQUEST_MIB: 128, - MINIMUM_REGEX_WORKER_HEAP_REQUEST_MIB: 7, + DEFAULT_REGEX_MATCHING_DEADLINE_MS: REA_INTERNAL_LIMITS.REGEX_DEFAULT_MATCHING_DEADLINE_MS, + DEFAULT_REGEX_WORKER_HEAP_REQUEST_MIB: REA_INTERNAL_LIMITS.REGEX_DEFAULT_WORKER_HEAP_REQUEST_MIB, + MINIMUM_REGEX_WORKER_HEAP_REQUEST_MIB: REA_INTERNAL_LIMITS.REGEX_MINIMUM_WORKER_HEAP_REQUEST_MIB, } as const; export interface RegexWorkerTarpitResult {