From 076b736908443a777a4499f3e73e70fa4c7b4f39 Mon Sep 17 00:00:00 2001 From: DeryFerd Date: Tue, 17 Nov 2026 00:45:00 +0700 Subject: [PATCH] fix(runtime): require a plain identifier for self-seal / sidecar bindingName overrides generateSelfSealSnippet and generateSidecarJsPreamble interpolated the caller-provided bindingName verbatim into var declarations, so a hostile override could break or inject into the emitted preamble. Validate against an identifier pattern and fail loudly instead. --- src/shields/runtime/self-seal.ts | 6 ++++++ src/shields/runtime/sidecar-entangle.ts | 5 +++++ tests/self-seal.test.ts | 16 ++++++++++++++++ tests/sidecar-js-inject.test.ts | 21 +++++++++++++++++++++ 4 files changed, 48 insertions(+) diff --git a/src/shields/runtime/self-seal.ts b/src/shields/runtime/self-seal.ts index ebcd4cb..7156abb 100644 --- a/src/shields/runtime/self-seal.ts +++ b/src/shields/runtime/self-seal.ts @@ -352,6 +352,12 @@ export function generateSelfSealSnippet( const bindingName = options.bindingName ?? prng.identifier({ style: "camel", hint: "integrityDigest", entropy: 4 }); + // The name is interpolated verbatim into `var = …` declarations, so + // anything that is not a plain identifier would break or inject into the + // generated preamble. + if (!/^[$A-Za-z_][$A-Za-z0-9_]*$/.test(bindingName)) { + throw new Error("self-seal bindingName must be a valid JavaScript identifier"); + } const envFingerprint = options.envFingerprint !== false; const siblings = (options.siblingPaths ?? []).filter( (p) => typeof p === "string" && p.length > 0, diff --git a/src/shields/runtime/sidecar-entangle.ts b/src/shields/runtime/sidecar-entangle.ts index b45db0b..14558c3 100644 --- a/src/shields/runtime/sidecar-entangle.ts +++ b/src/shields/runtime/sidecar-entangle.ts @@ -464,6 +464,11 @@ export function generateSidecarJsPreamble( } const tag = expectedHex.slice(0, 8); const bindingName = options.bindingName ?? `_verifySiblingDigest_${tag}`; + // Interpolated verbatim into `var = …` declarations — require a plain + // identifier so an override cannot break or inject into the preamble. + if (!/^[$A-Za-z_][$A-Za-z0-9_]*$/.test(bindingName)) { + throw new Error("sidecar bindingName must be a valid JavaScript identifier"); + } const expectedU32 = parseInt(tag, 16) >>> 0; const sidecarsLiteral = JSON.stringify(sidecars); const entryLiteral = JSON.stringify(options.entryPath); diff --git a/tests/self-seal.test.ts b/tests/self-seal.test.ts index 96d32bb..c31d9c5 100644 --- a/tests/self-seal.test.ts +++ b/tests/self-seal.test.ts @@ -37,6 +37,22 @@ describe("self-seal helper (#40.5)", () => { expect(snip.code.toLowerCase()).not.toMatch(/\bbla[_-]?seal\b/); }); + it("rejects a bindingName that is not a JavaScript identifier", () => { + const prng = new SeededPrng("self-seal-unit-hostile"); + expect(() => + generateSelfSealSnippet(prng, { + siblingPaths: ["./sib-a.js"], + bindingName: "x; alert(1);//", + }), + ).toThrow(/identifier/); + // PRNG-derived names stay valid. + expect(() => + generateSelfSealSnippet(new SeededPrng("self-seal-unit-derived"), { + siblingPaths: ["./sib-a.js"], + }), + ).not.toThrow(); + }); + it("offline digest helper is deterministic for identical inputs", () => { const a = measureSelfSealDigestOffline([ { pathLabel: "main.js", bytes: Buffer.from("hello-module") }, diff --git a/tests/sidecar-js-inject.test.ts b/tests/sidecar-js-inject.test.ts index 539e990..741e0ee 100644 --- a/tests/sidecar-js-inject.test.ts +++ b/tests/sidecar-js-inject.test.ts @@ -58,6 +58,27 @@ describe("sidecar JS inject strip⇒fail (vertical slice)", () => { ).toThrow(/64-char/); }); + it("generateSidecarJsPreamble rejects a bindingName that is not a JS identifier", () => { + const hex = "a".repeat(64); + expect(() => + generateSidecarJsPreamble({ + entryPath: "main.js", + sidecarPaths: ["sib.js"], + expectedHex: hex, + bindingName: "x; alert(1);//", + }), + ).toThrow(/identifier/); + // Valid identifiers stay accepted. + expect(() => + generateSidecarJsPreamble({ + entryPath: "main.js", + sidecarPaths: ["sib.js"], + expectedHex: hex, + bindingName: "_verifySiblingDigest_ok1", + }), + ).not.toThrow(); + }); + it("bindSidecarEntanglement returns status bound with inject + digest", () => { const entryBytes = new TextEncoder().encode("module.exports = { ok: true };\n"); const sibBytes = new TextEncoder().encode("sidecar-payload\n");